Add ECS0005: prefer formattablestring for culture specific strings #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmurillo
added
documentation
rjmurillo
added
.NET
and removed
build
dependencies
…estring-for-culture-specific-strings
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
rjmurillo
force-pushed
the
feature/issue-29-prefer-formattablestring-for-culture-specific-strings
branch
from
cc6f104 to
c8a3ce1
Compare
rjmurillo
commented
Aug 12, 2024
src/EffectiveCSharp.Analyzers/FormattableStringForCultureSpecificStringsAnalyzer.cs
Outdated
Show resolved
Hide resolved
rjmurillo
commented
Aug 12, 2024
src/EffectiveCSharp.Analyzers/FormattableStringForCultureSpecificStringsAnalyzer.cs
Outdated
Show resolved
Hide resolved
…ce for .NET Framework and .NET 6+
rjmurillo
force-pushed
the
feature/issue-29-prefer-formattablestring-for-culture-specific-strings
branch
from
7977558 to
8ca44f8
Compare
rjmurillo
force-pushed
the
feature/issue-29-prefer-formattablestring-for-culture-specific-strings
branch
from
5601654 to
efbeb91
Compare
rjmurillo
commented
Aug 13, 2024
rjmurillo
deleted the
feature/issue-29-prefer-formattablestring-for-culture-specific-strings
branch
rjmurillo
added a commit
that referenced
this pull request
Aug 19, 2024
This pull request introduces a new Roslyn analyzer and associated code fix provider to enforce best practices for culture-specific string formatting in C#. The analyzer identifies cases where `FormattableString` or `string.Create` should be used instead of string for interpolated strings, depending on the target framework version. The code fix provider automatically suggests the appropriate replacement. ## Changes - Analyzer: `FormattableStringForCultureSpecificStringsAnalyzer` - Detects culture-specific string usage and recommends either `FormattableString`, `string.Create`, or `string.Format` based on the .NET version. - Code Fix Provider: `FormattableStringForCultureSpecificStringsCodeFixProvider` - Provides automated fixes based on the analyzer's recommendations. - Tests: Comprehensive unit tests covering various scenarios, including different .NET versions and complex string interpolation cases. This analyzer aligns modern C# and .NET practices, particularly Stephen Toub's guidance on using `string.Create` in .NET 6+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Roslyn analyzer and associated code fix provider to enforce best practices for culture-specific string formatting in C#. The analyzer identifies cases where
FormattableStringorstring.Createshould be used instead of string for interpolated strings, depending on the target framework version. The code fix provider automatically suggests the appropriate replacement.Changes
FormattableStringForCultureSpecificStringsAnalyzerFormattableString,string.Create, orstring.Formatbased on the .NET version.FormattableStringForCultureSpecificStringsCodeFixProviderThis analyzer aligns modern C# and .NET practices, particularly Stephen Toub's guidance on using
string.Createin .NET 6+